Google Oauth button redesigned and refactored the button component#13
Open
aravind289 wants to merge 2 commits intodevelopfrom
Open
Google Oauth button redesigned and refactored the button component#13aravind289 wants to merge 2 commits intodevelopfrom
aravind289 wants to merge 2 commits intodevelopfrom
Conversation
digi0ps
requested changes
Aug 1, 2020
| import React from 'react' | ||
| import styles from './ui.module.css' | ||
| import GoogleLogo from '../../../images/g.png' | ||
| export default function GoogleButton({ onClick, textLabel }) { |
| selectedOption: option, | ||
| }) | ||
| } | ||
| render() { |
| } | ||
|
|
||
| toggleRadioCheck = (e) => { | ||
| var option = e.target.value |
| toggleRadioCheck = (e) => { | ||
| var option = e.target.value | ||
| this.setState({ | ||
| selectedOption: option, |
Member
There was a problem hiding this comment.
Or actually no variable needed. Just do:
selectedOption: e.target.value
| const labelOrientation = 'vertical', | ||
| dropdownData = ['All Time', 'Weekly', 'Monthly'], | ||
| const dropdownData = ['All Time', 'Weekly', 'Monthly'], | ||
| labelData = [ |
Member
There was a problem hiding this comment.
Declare labelData in a separate const
| }, | ||
| ] | ||
| const dropdownOptions = ['All', 'Practise', 'Arena'] | ||
| // labelData = [ |
Member
There was a problem hiding this comment.
Why is this commented? If it's not used delete it
| // console.log('Given Name: ' + profile.getGivenName()) | ||
| // console.log('Family Name: ' + profile.getFamilyName()) | ||
| // console.log('Image URL: ' + profile.getImageUrl()) | ||
| // console.log('Email: ' + profile.getEmail()) |
| {/* <div id="customBtn" className="customGPlusSignIn" onClick={this.onSignIn}> | ||
| <span className="icon"><img className="googleLogo" src={GoogleLogo} alt="glogo"></img></span> | ||
| <span className="buttonText">Sign Up With Google</span> | ||
| </div> */} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.